Refact: hide dropdown prompt & palette when clicked outside #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an event listener to hide prompts, when anything other than the dropdown is clicked, implemented via a click event.
Added an event listener to hide palette color, when anything other than the dropdown palette is clicked, implemented via a click event.
ztjhz
requested changes
Apr 11, 2023
There was a problem hiding this comment.
Please look at this PR #211.
The event listener should only be added when the dropdown is toggled and removed when the dropdown is removed. Otherwise, there will be multiple mousedown event listeners for every rendered CommandPrompt there is.
Changed the event listener conditions for mousedown events, so they are only added when dropdown menu or color palette is visible.
Well noted, it makes sense. Fixed with a new commit. |
ztjhz
approved these changes
Apr 12, 2023
ElonGaties
added a commit
to ElonGaties/BetterChatGPT
that referenced
this pull request
Apr 12, 2023
Refact: hide dropdown prompt & palette when clicked outside (ztjhz#223)
ElonGaties
added a commit
to ElonGaties/BetterChatGPT
that referenced
this pull request
Apr 12, 2023
Refact: hide dropdown prompt & palette when clicked outside (ztjhz#223)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an event listener to hide dropdown,
when anything other than the dropdown is clicked,
implemented via a click event.