Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choice field should pass their context to VocubalyrRegistry.get #54

Closed
jamadden opened this issue Sep 4, 2018 · 1 comment
Closed

Choice field should pass their context to VocubalyrRegistry.get #54

jamadden opened this issue Sep 4, 2018 · 1 comment
Assignees
@jamadden
Labels
bug enhancement

Comments

@jamadden
Copy link
Member

jamadden commented Sep 4, 2018

Currently they always pass a hardcoded None, meaning that IVocubalaryFactory instances only ever get a hardcoded None. If they're bound, they should pass their context

This should be backwards compatible, existing factories should be ignoring this previously-useless argument.
@jamadden jamadden self-assigned this Sep 4, 2018
@jamadden
Copy link
Member Author

jamadden commented Sep 4, 2018

Hmm, that's not quite right. During the binding process, Choice eagerly resolves its vocabulary name using the context. That means that the lookup process in _validate should only be happening for unbound fields.

There's still some discrepancies there, though, in terms of what exceptions get raised when.

jamadden added a commit that referenced this issue Sep 4, 2018
@jamadden
Make resolving a vocabulary consistent for bound and unbound fields s…
8033a95 
…o we get good error messages always. Fixes #54.
@jamadden jamadden mentioned this issue Sep 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamadden jamadden

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamadden