Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IFieldUpdatedEvent not correctly implemented by FieldUpdatedEvent. #102

Closed
janwijbrand opened this issue Jan 25, 2021 · 0 comments · Fixed by #103
Closed

IFieldUpdatedEvent not correctly implemented by FieldUpdatedEvent. #102

janwijbrand opened this issue Jan 25, 2021 · 0 comments · Fixed by #103

Comments

@janwijbrand
Copy link
Member

BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)

What I did:

I looked at IFieldUpdatedEvent and noticed it declares an object attribute. Then I looked at the FieldUpdatedEvent implementation and noticed it does not comply and implements an inst attribute instead.

What I expect to happen:

I expected FieldUpdatedEvent to comply with the interfaces it implements.

What actually happened:

It didnt.

I made PR that fixes this issue and also leaves a BBB inst in place for now. Not sure what policy to follow to get rid of it.
janwijbrand added a commit to minddistrict/zope.schema that referenced this issue Jan 25, 2021
@janwijbrand
Fix FieldUpdateEvent implementation by having an object attribute a…
6104663 
…s the `IFieldUpdatedEvent` interfaces claims there should be. Fixes zopefoundation#102
@janwijbrand janwijbrand mentioned this issue Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IFieldUpdatedEvent not correctly implemented by FieldUpdatedEvent minddistrict/zope.schema
1 participant
@janwijbrand