Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monkey patch iris and speed up crunching #72

Merged
merged 27 commits into from
Jul 19, 2019
Merged

Conversation

znicholls
Copy link
Owner

@znicholls znicholls commented Jul 15, 2019

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Example added (either to an existing notebook or as a new notebook, where applicable)
  • Description in CHANGELOG.rst added

Adding to CHANGELOG.rst

Please add a single line in the changelog notes similar to one of the following:

- (`#XX <http:https://link-to-pr.com>`_) Added feature which does something
- (`#XX <http:https://link-to-pr.com>`_) Fixed bug identified in (`#XX <http:https://link-to-issue.com>`_)

Supercedes #68

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #72 into master will increase coverage by 0.65%.
The diff coverage is 96.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   97.63%   98.29%   +0.65%     
==========================================
  Files          10       10              
  Lines        1184     1287     +103     
  Branches      165      184      +19     
==========================================
+ Hits         1156     1265     +109     
+ Misses         18       16       -2     
+ Partials       10        6       -4
Impacted Files Coverage Δ
src/netcdf_scm/masks/__init__.py 98.94% <100%> (+3.15%) ⬆️
src/netcdf_scm/utils.py 100% <100%> (+2.89%) ⬆️
src/netcdf_scm/iris_cube_wrappers.py 99.02% <100%> (-0.14%) ⬇️
src/netcdf_scm/cli.py 95.61% <95.12%> (+0.97%) ⬆️
src/netcdf_scm/wranglers.py 100% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd15ce8...f3019a4. Read the comment docs.

@znicholls znicholls changed the title Parallel crunching 2 Monkey patch iris and speed up crunching Jul 16, 2019
@znicholls znicholls mentioned this pull request Jul 16, 2019
4 tasks
@znicholls
Copy link
Owner Author

Twice the monkey @rgieseke :)

image

image

@znicholls znicholls force-pushed the parallel-crunching-2 branch 2 times, most recently from 182d3ea to c74582c Compare July 18, 2019 02:03
@znicholls
Copy link
Owner Author

@rgieseke I found the issues in iris which illustrate this issue: SciTools/iris#3333 SciTools/iris#3357

@znicholls znicholls marked this pull request as ready for review July 18, 2019 02:28
@znicholls znicholls merged commit bb5b6bf into master Jul 19, 2019
@znicholls znicholls deleted the parallel-crunching-2 branch July 19, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant