fix: Disable display feature for settings_reset #2628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, fixing the status screens would be the ideal solution, but you're probably not going to think to do that when writing a custom status screen for a board that always supports BLE. This seems reasonable to me. |
joelspadin
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this tweak, a build like
west build -b corneish_zen_v2_left -- -DSHIELD=settings_resetfails because the status screens are enabled and they expect certain APIs related to e.g. BT profiles that don't get built. This can be an issue with any onboard controller keyboard that enables a display with status screen by default, like ones that live in modules. While good practice would be to#if definedguard the appropriate widgets, there is also no reason to have display enabled with settings reset.