Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB Underglow: Auto off on idle #1179

Closed

Conversation

infused-kim
Copy link
Contributor

This PR adds an auto off on idle feature to the underglow. It's already supported for the backlight and this adds a similar setting to the underglow.

I have tested it on my sofle choc and it's working great.

@infused-kim infused-kim force-pushed the my-changes/underglow-auto-off branch 2 times, most recently from f38be82 to d10d9f7 Compare March 24, 2022 07:17
@infused-kim
Copy link
Contributor Author

I realized my initial commit had a bug.

zmk_rgb_underglow_offand zmk_rgb_underglow_on save the state to the config. So if the user has underglow on, then idles and the underglow is auto-turned off, that setting saved into the flash. If the user turns off and on their keyboard, it starts in the underglow off state even though the user never changed that setting.

The new commit ensures the auto-off feature is only active if the underglow is on and that it doesn't save the temporary off state into the config.

@infused-kim infused-kim force-pushed the my-changes/underglow-auto-off branch from d10d9f7 to 6a8b643 Compare April 3, 2022 08:58
@infused-kim infused-kim force-pushed the my-changes/underglow-auto-off branch from 6a8b643 to 6772256 Compare April 29, 2022 08:16
@petejohanson
Copy link
Contributor

Thanks for the PR, @infused-kim!

Can you please try with the latest main? You'll need to enable the new Kconfig option to enable the functionality.

@autoferrit
Copy link

This seems like a smaller change. is anything other than review needed to get this in? is there any way I can help? I am new to c/zmk but could try.

@lesshonor
Copy link
Contributor

This PR appears to have been obsoleted by #1010, which was merged in June 2023.

@caksoylar caksoylar closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants