Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of Subject:commonName not present in lint for BR 7.1.4.2.2a mailbox-validated #845

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix handling of Subject:commonName not present in lint for BR 7.1.4.2.2a mailbox-validated #845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68eca78
Fix handling of Subject:commonName not present in lint for BR 7.1.4.2…
robstradling May 24, 2024
6fd4171
Add test case for no commonName attribute present
robstradling May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion v3/lints/cabf_smime_br/lint_commonname_mailbox_validated.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,10 @@ func (l *commonNameMailboxValidated) CheckApplies(c *x509.Certificate) bool {
}

func (l *commonNameMailboxValidated) Execute(c *x509.Certificate) *lint.LintResult {
commonNames := []string{c.Subject.CommonName}
var commonNames []string
if c.Subject.CommonName != "" {
commonNames = append(commonNames, c.Subject.CommonName)
}
commonNames = append(commonNames, c.Subject.CommonNames...)
for _, cn := range commonNames {
if !util.IsMailboxAddress(cn) {
Expand Down
5 changes: 5 additions & 0 deletions v3/lints/cabf_smime_br/lint_commonname_mailbox_validated_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ func TestCommonNameMailboxValidated(t *testing.T) {
InputFilename string
ExpectedResult lint.LintStatus
}{
{
Name: "pass - no commonName attribute present",
InputFilename: "smime/mailbox_validated_common_name_absent.pem",
ExpectedResult: lint.Pass,
},
{
Name: "pass - valid email in commonName",
InputFilename: "smime/mailbox_validated_common_name_good_email.pem",
Expand Down
30 changes: 30 additions & 0 deletions v3/testdata/smime/mailbox_validated_common_name_absent.pem
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
-----BEGIN CERTIFICATE-----
MIIFODCCBCCgAwIBAgIRAIe9uh1DAJY6+ckykEvuYmAwDQYJKoZIhvcNAQELBQAw
gZYxCzAJBgNVBAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAO
BgNVBAcTB1NhbGZvcmQxGDAWBgNVBAoTD1NlY3RpZ28gTGltaXRlZDE+MDwGA1UE
AxM1U2VjdGlnbyBSU0EgQ2xpZW50IEF1dGhlbnRpY2F0aW9uIGFuZCBTZWN1cmUg
RW1haWwgQ0EwHhcNMjQwMTAyMDAwMDAwWhcNMjUxMjIyMjM1OTU5WjAuMSwwKgYJ
KoZIhvcNAQkBFh1tYXJ0aWpuLmthdGVyYmFyZ0BzZWN0aWdvLmNvbTCCASIwDQYJ
KoZIhvcNAQEBBQADggEPADCCAQoCggEBALQMuh2c7ECmRnd1XLJShvJEZnoR3MyI
e8RJ+Or/QfjTEAF4XYWnS+d4wO9L0Se5pCsdo/WysGjRsQGBvyaiQiSf3XLjCGyF
9R9STrSFomKSkev1fHdoOzQI0PsnjbNmyiBhJJdqFluzr2y6jQxn81WjVaGylMEn
SHF3rLtLgsOMJA2T233mkKtnlitBNA1Hf83QEdSfnilgr0z7WBp+4EiZVIJycjF8
pNTzOSgPPSMFZe8O6HAjAwRwi4e0s/EmL9AI0fwqaKBaI0OTSt1SyforbZHvMwPZ
I041fF3qa6htrLSjzMitoyaV2A6xXV2dFhGz+2I0bAWCPX2tEv17UUsCAwEAAaOC
AeYwggHiMB8GA1UdIwQYMBaAFAnA8vwL2pTbX/4r36iZQs/J4K0AMB0GA1UdDgQW
BBR9V1qzZfoGq21Yj/3IPgibG+PQozAOBgNVHQ8BAf8EBAMCBaAwDAYDVR0TAQH/
BAIwADAdBgNVHSUEFjAUBggrBgEFBQcDBAYIKwYBBQUHAwIwUAYDVR0gBEkwRzA6
BgwrBgEEAbIxAQIBCgEwKjAoBggrBgEFBQcCARYcaHR0cHM6Ly9zZWN0aWdvLmNv
bS9TTUlNRUNQUzAJBgdngQwBBQECMFoGA1UdHwRTMFEwT6BNoEuGSWh0dHA6Ly9j
cmwuc2VjdGlnby5jb20vU2VjdGlnb1JTQUNsaWVudEF1dGhlbnRpY2F0aW9uYW5k
U2VjdXJlRW1haWxDQS5jcmwwgYoGCCsGAQUFBwEBBH4wfDBVBggrBgEFBQcwAoZJ
aHR0cDovL2NydC5zZWN0aWdvLmNvbS9TZWN0aWdvUlNBQ2xpZW50QXV0aGVudGlj
YXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAjBggrBgEFBQcwAYYXaHR0cDovL29j
c3Auc2VjdGlnby5jb20wKAYDVR0RBCEwH4EdbWFydGlqbi5rYXRlcmJhcmdAc2Vj
dGlnby5jb20wDQYJKoZIhvcNAQELBQADggEBAKnvAa8vJTFT05bt8qVa+KaLiXPa
qmbfMvtXDU0OyZD5tJxp5kxpaT7IP4n5cOchFbNqI9rNyny3XNHBTd5eKtPoUein
ynP7tgJfrzG7YRzPfz/tOC2Y2VAhSAuaQ8bAmvNUq8xU3rgWyKtDTYBMraWFSIaK
g+VwORwFn2cv0FqOhDa0vlheSBFleuyxuEiFi40pnA5fvCFNUQes5SVorBSSydiM
hjyu0EoeVlvUiScP96PIeZL04HfBzA4KtAFAGwhA18GrtO4aWux2DNXYPs+saiNq
V3bMmP5h8JfwRoGKiLm7b37wfKlSkRlIrDY6WpBTOdidGc6gEuSOugJ0X3g=
-----END CERTIFICATE-----
Loading