Policy Qualifiers other than id-qt-cps are no longer allowed as per CABF BRs #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I originally set out to search for User Notice, in fact all qualifiers are now a MUST NOT, except for id-qt-cps. PR and lint description updated to reflect proper language |
zakird
requested changes
Nov 25, 2023
Done. Thank you for that suggestion. Likewise, function names have been updated |
zakird
approved these changes
Nov 26, 2023
|
Looks good to me. @christopher-henderson do you want to quickly 👀 look over, or good to merge from your POV? |
christopher-henderson
approved these changes
Nov 27, 2023
| X509v3 Authority Key Identifier: | ||
| 01:02:03 | ||
| X509v3 Certificate Policies: | ||
| 0..F0.. ..g.....0...0...+.......0.0.....+.......0..0..0.............An explicitText field includes the textual statement directly in the certificate. The explicitText field is a string with a maximum size of 200 characters. Conforming CAs SHOULD use the UTF8String encoding for explicitText. 0.....*...0...0...+.......0.0.....+.......0..0..0.............An explicitText field includes the textual statement directly in the certificate. The explicitText field is a string with a maximum size of 200 characters. Conforming CAs SHOULD use the UTF8String encoding for explicitText. |
There was a problem hiding this comment.
Clever use of the test certificate to also document what the certificate is testing 😉
There was a problem hiding this comment.
Noted for my next time!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of SC-62, only the cps policy qualifier is allowed in any certificate type.