E ext cert policy disallowed any policy qualifier refactor #732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint e_ext_cert_policy_disallowed_any_policy_qualifier checks whether the CpsOID or UserNoticeOID policy qualifiers are present. It does not evaluate whether anyPolicy is present. In this implementation it is iterated over all policies, checked whether a policy is the anyPolicy and then checked whether the qualifiers for this policy are the allowed ones. The implementation is based on code snippets from v3/util/oid.go GetMappedPolicies function. Also the check applies does not only check whether the extension is present but also whether one of the policies is the anyPolicy, and has a small TODO for discussion whether to implement this as a utility function "HasAnyPolicyOID". Also new certificates have been issued to test the behaviour of the lint.