Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(devcontainer): improve devcontainer to work on windows and linux #8194

Merged
merged 3 commits into from
Jun 25, 2024
Merged

chore(devcontainer): improve devcontainer to work on windows and linux #8194

merged 3 commits into from
Jun 25, 2024

Conversation

fforootd
Copy link
Member

@fforootd fforootd commented Jun 25, 2024 •
edited
Loading

Which Problems Are Solved

Working on windows with a devcontainer has line ending issues which are solved with the .gitattributes file

Source from here https://code.visualstudio.com/docs/devcontainers/tips-and-tricks#_resolving-git-line-ending-issues-in-containers-resulting-in-many-modified-files

@vercel Vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 2:12pm

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited by fforootd
Loading

Thanks for your contribution @fforootd! 🎉

Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:

  • I am happy with the code
  • Documentations and examples are up-to-date
  • Logical behavior changes are tested automatically
  • No debug or dead code
  • My code has no repetitions
  • The PR title adheres to the conventional commit format
  • The example texts in the PR description are replaced.
  • If there are any open TODOs or follow-ups, they are described in issues and link to this PR
  • If there are deviations from a user stories acceptance criteria or design, they are agreed upon with the PO and documented.

@fforootd fforootd requested a review from muhlemmer June 25, 2024 13:29
@fforootd fforootd enabled auto-merge (squash) June 25, 2024 13:29
@fforootd fforootd self-assigned this Jun 25, 2024
muhlemmer
muhlemmer reviewed Jun 25, 2024
View reviewed changes
gitattributes Outdated Show resolved Hide resolved
@fforootd fforootd merged commit 3af825a into main Jun 25, 2024
25 checks passed
@fforootd fforootd deleted the devcontainers branch June 25, 2024 14:40
brandonkal pushed a commit to brandonkal/zitadel that referenced this pull request Jun 26, 2024
@fforootd @brandonkal
chore(devcontainer): improve devcontainer to work on windows and linux (
eb8806f 
zitadel#8194)

# Which Problems Are Solved

Working on windows with a devcontainer has line ending issues which are
solved with the .gitattributes file
muhlemmer pushed a commit that referenced this pull request Jul 2, 2024
@fforootd @muhlemmer
chore(devcontainer): improve devcontainer to work on windows and linux (
31d5ef2 
#8194)

# Which Problems Are Solved

Working on windows with a devcontainer has line ending issues which are
solved with the .gitattributes file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muhlemmer muhlemmer muhlemmer approved these changes

Assignees

@fforootd fforootd

Labels
None yet
Projects
Product Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fforootd @muhlemmer