Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): use gh action to build docs #8097

Merged
merged 52 commits into from
Jun 13, 2024
Merged

chore(docs): use gh action to build docs #8097

merged 52 commits into from
Jun 13, 2024

Conversation

fforootd
Copy link
Member

@fforootd fforootd commented Jun 10, 2024

Which Problems Are Solved

This allows us to build multiple docs in parallel and only runs when docs/proto are changed.

Additional Changes

  • Change "required" in GitHub from Vercel to the docs flow

@fforootd fforootd self-assigned this Jun 10, 2024
Copy link

github-actions bot commented Jun 10, 2024

Thanks for your contribution @fforootd! 🎉

Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:

  • I am happy with the code
  • Documentations and examples are up-to-date
  • Logical behavior changes are tested automatically
  • No debug or dead code
  • My code has no repetitions
  • The PR title adheres to the conventional commit format
  • The example texts in the PR description are replaced.
  • If there are any open TODOs or follow-ups, they are described in issues and link to this PR
  • If there are deviations from a user stories acceptance criteria or design, they are agreed upon with the PO and documented.

Copy link

github-actions bot commented Jun 12, 2024

Your build has completed!

Preview deployment

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.07%. Comparing base (206d947) to head (83de779).
Report is 1 commits behind head on main.

Current head 83de779 differs from pull request most recent head fd66606

Please upload reports for the commit fd66606 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8097      +/-   ##
==========================================
- Coverage   62.08%   62.07%   -0.01%     
==========================================
  Files        1400     1400              
  Lines      112844   112844              
==========================================
- Hits        70054    70052       -2     
- Misses      38858    38859       +1     
- Partials     3932     3933       +1     
Flag Coverage Δ
core-integration-tests-postgres 62.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fforootd fforootd requested a review from livio-a June 12, 2024 15:54
@fforootd fforootd marked this pull request as ready for review June 12, 2024 15:54
@livio-a
Copy link
Member

livio-a commented Jun 13, 2024

@fforootd don't we also need a succeed step on case the filter output is false? otherwise, non docs PRs will not be mergeable

@fforootd
Copy link
Member Author

@fforootd don't we also need a succeed step on case the filter output is false? otherwise, non docs PRs will not be mergeable

I tested what happens then. It skips all further checks and skipped checks make the whole job a success

@zitadel zitadel deleted a comment from vercel bot Jun 13, 2024
@livio-a livio-a enabled auto-merge (squash) June 13, 2024 07:43
@livio-a livio-a merged commit c9e3520 into main Jun 13, 2024
24 checks passed
@livio-a livio-a deleted the docusaurus-gh-action branch June 13, 2024 08:07
@zitadel zitadel deleted a comment from github-actions bot Jun 13, 2024
livio-a added a commit that referenced this pull request Jun 21, 2024
# Which Problems Are Solved

This allows us to build multiple docs in parallel and only runs when
docs/proto are changed.

# Additional Changes

- [ ] Change "required" in GitHub from Vercel to the docs flow

---------

Co-authored-by: Livio Spring <[email protected]>
Copy link

🎉 This PR is included in version 2.55.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

brandonkal pushed a commit to brandonkal/zitadel that referenced this pull request Jun 26, 2024
# Which Problems Are Solved

This allows us to build multiple docs in parallel and only runs when
docs/proto are changed.

# Additional Changes

- [ ] Change "required" in GitHub from Vercel to the docs flow

---------

Co-authored-by: Livio Spring <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants