Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update jwtProfileKeySet to match actual use #219

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

muir
Copy link
Contributor

@muir muir commented Sep 27, 2022

What is actually stored in jwtProfileKeySet is a client id. It is not a user id.
This change makes no functional difference, it just removes some naming technical debt.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #219 (d90be35) into main (0e7949b) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   12.47%   12.46%   -0.02%     
==========================================
  Files          41       41              
  Lines        3263     3266       +3     
==========================================
  Hits          407      407              
- Misses       2845     2848       +3     
  Partials       11       11              
Impacted Files Coverage Δ
pkg/op/auth_request.go 43.83% <0.00%> (ø)
pkg/op/verifier_jwt_profile.go 0.00% <0.00%> (ø)
pkg/oidc/userinfo.go 39.62% <0.00%> (-0.51%) ⬇️
pkg/oidc/introspection.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@livio-a livio-a merged commit 4b4b0e4 into zitadel:main Sep 30, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants