Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up FunctionDefSpec #679

Open
1 of 2 tasks
sviezypan opened this issue May 26, 2022 · 1 comment
Open
1 of 2 tasks

Clean up FunctionDefSpec #679

sviezypan opened this issue May 26, 2022 · 1 comment
Labels

Comments

@sviezypan
Copy link
Collaborator

sviezypan commented May 26, 2022

Lots of tests in ZIO SQL were written in past, when some operators were not yet available.

In many places we could simplify, for example:

     ....
      val expected = ???
      val assertion = for {
        r <- testResult.runCollect
      } yield assert(r.head)(equalTo(expected))

      assertion.mapErrorCause(cause => Cause.stackless(cause.untraced))

to

assertZIO(testResult.runHead.some)(equalTo(expected))

This is to be done in two modules:

  • MySQL
  • PostgreSQL
@sarahotoole
Copy link
Contributor

I'll take this one

sarahotoole added a commit to sarahotoole/zio-sql that referenced this issue May 26, 2022
sarahotoole added a commit to sarahotoole/zio-sql that referenced this issue May 26, 2022
jczuchnowski pushed a commit that referenced this issue May 26, 2022
vidyasankarv added a commit to vidyasankarv/zio-sql that referenced this issue May 27, 2022
vidyasankarv added a commit to vidyasankarv/zio-sql that referenced this issue May 27, 2022
vidyasankarv added a commit to vidyasankarv/zio-sql that referenced this issue May 27, 2022
sviezypan added a commit that referenced this issue May 27, 2022
#679 - cleanup postgres FunctionDefSpec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants