Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ReadExecutor, verify a statement execution returns a ResultSet #63

Closed
jdegoes opened this issue Sep 8, 2020 · 1 comment
Closed

Comments

@jdegoes
Copy link
Member

jdegoes commented Sep 8, 2020

Currently, the boolean value returned from Statement#execute in ReadExecutor is ignored. It should be checked, and if false, it means there is no result set being returned, which we should handle appropriately rather than just calling getResultSet().

@TobiasPfeifer
Copy link
Contributor

even SELECT NULL LIMIT 0; returns a ResultSet (empty). I couldn't figure out a way to get Statement#execute return false for a SELECT. And I don't think someone can sneak in an update into a Read[A] that gets reflected as having no ResultSet

However just to handle all corner cases I would suggest to return an empty result stream.

I'll give this a try

TobiasPfeifer added a commit to TobiasPfeifer/zio-sql that referenced this issue Mar 29, 2021
jczuchnowski added a commit that referenced this issue Jun 7, 2021
…result

Verify a statement execution returns a ResultSet #63
amrkamel pushed a commit to amrkamel/zio-sql that referenced this issue May 26, 2022
amrkamel pushed a commit to amrkamel/zio-sql that referenced this issue May 26, 2022
…on-result

Verify a statement execution returns a ResultSet zio#63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants