-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In ReadExecutor, verify a statement execution returns a ResultSet #63
Comments
even However just to handle all corner cases I would suggest to return an empty result stream. I'll give this a try |
TobiasPfeifer
added a commit
to TobiasPfeifer/zio-sql
that referenced
this issue
Mar 29, 2021
jczuchnowski
added a commit
that referenced
this issue
Jun 7, 2021
…result Verify a statement execution returns a ResultSet #63
amrkamel
pushed a commit
to amrkamel/zio-sql
that referenced
this issue
May 26, 2022
amrkamel
pushed a commit
to amrkamel/zio-sql
that referenced
this issue
May 26, 2022
…on-result Verify a statement execution returns a ResultSet zio#63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the boolean value returned from
Statement#execute
inReadExecutor
is ignored. It should be checked, and iffalse
, it means there is no result set being returned, which we should handle appropriately rather than just callinggetResultSet()
.The text was updated successfully, but these errors were encountered: