ZLayer visualization #473
Draft
ZLayer visualization #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmemcpy
commented
May 20, 2024
| case Left(buildErrors) => Left(graphToConstructionErrors(buildErrors)) | ||
| case Right(tree) => | ||
| // forgive me for I have side-effected :( | ||
| expr.putUserData(GraphDataKey, tree) |
There was a problem hiding this comment.
forgive me @myazinn for I have sinned :D
(I need to recover the LayerTree somehow... any ideas are most welcome!)
There was a problem hiding this comment.
this feature look too good for me to grumble on side-effects 👍
There was a problem hiding this comment.
This desperately needs a State, but screw it :)
My initial approach was to duplicate the inspection logic inside the gutter, but I decided against it. Passing data in the element's cache is good enough for now.
Just need to tweak the gutter menu.
Thanks! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
This (mess of a) PR introduces the ZLayer gutter icon + supporting rendering the ZLayer graph as a mermaid diagram (currently using an online mermaid.js service, later will try to embed in IDEA directly)
