highlight unused tests #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hmemcpy
reviewed
Mar 13, 2023
| import org.jetbrains.plugins.scala.lang.psi.api.expr.ScExpression | ||
|
|
||
| // dirty hack to make expressionResultIsNotUsed public | ||
| // todo use original method directly when (if) it's a public API |
There was a problem hiding this comment.
I like this :) I would just rip the code, but I keep forgetting Scala can do this!
hmemcpy
approved these changes
Mar 13, 2023
|
<3 Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #402
Also improves detection of unused effects, now it can detect cases when effect is unused and followed by non-effect types like this
But I had to use internal plugin API to make it work :( I could just copy-pasted the whole method (wouldn't be the first time), but decided to use a temp hack. Hopefully it'll become a public API in the nearest releases. If not, we can use good old copy-pasting :)