Not detecting unused expression in zio-test specs?

[zalbia]

Expected behavior: Should detect unused expression, though I'm not sure if intended
Actual behavior: Unused expression not detected

Platform:

• Windows 10 (2004)
• Intellij 2020.3
• zio-intellij 2020.3.5.1
• Scala 2.13.5

Minimal reproduction:

import zio.test._

object Repro extends DefaultRunnableSpec {
  def spec = suite("Repro") {
    testM("foo") { ??? } // undetected unused expression
    testM("bar") { ??? }
  }
}

[hmemcpy]

Hmm. In the default spec, the suite expects a varargs list of tests, separated by commas. I don't think this would even compile, and intellij would definitely paint it all as red as a Christmas tree...
Not sure suite(...) { ... } even works (need to check), you have to place it in parentheses.

The new ZIO has a DefaultMutableRunnableSpec where you can place top-level test/testMs without separating them by commas.

Either way, let me see if I could detect such missing commas and offer to add them!

[zalbia]

It compiles for me, here it is in Scastie. This boils down to my misuse of specs: Spec[R, E, T]*. Like you said, it should be parens instead of curly brackets. So what ends up happening is only the last test gets run, which in the Scastie is shown as the Fiber failing on line 6, but not on line 5.

[myazinn]

Closed here.

[hmemcpy]

I think this might not be related. The + operator is for zio test in 2.0, the ZIO 1 tests needed to be comma-separated AFAIK

[myazinn]

@hmemcpy seems to work fine with ZIO 1.0.17 (haven't checked other lower versions)