Fix error when extracting examples (#2789) #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66bccf2
to
9612d18
Compare
jdegoes
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jdegoes this is a fix, but seems fishy.I debugged and realised, that we have in the changed line an alternator of type right empty. Which comes from the call of
outCodec. This is correct, since the type of out before is empty. But the example value is wrapped in a left it needs to be unwrapped. Which only happens for an either alternator. Maybe you have an idea what could go wrong here?@jdegoes I found the actual issue. The
def |only throw aways an incomingHttpCodec.Halt, but it needs to ignore self if it isHttpCodec.Haltas well.Question:
Does it make more sense to check
self eq Haltor overridedef |forHalt?fixes #2789
/claim #2789