Add prefix method to Route/Routes
#2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29413a0
to
ecfe87b
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2547 +/- ##
==========================================
- Coverage 64.28% 64.22% -0.06%
==========================================
Files 138 138
Lines 7977 7987 +10
Branches 1483 1471 -12
==========================================
+ Hits 5128 5130 +2
- Misses 2849 2857 +8 ☔ View full report in Codecov by Sentry. |
jdegoes
reviewed
Dec 8, 2023
| @@ -120,6 +119,16 @@ sealed trait Route[-Env, +Err] { self => | |||
| */ | |||
| def location: Trace | |||
|
|
|||
| def prefix(prefix: PathCodec[Unit])(implicit ev: Err <:< Response): Route[Env, Err] = | |||
There was a problem hiding this comment.
Shouldn't this be called nest, because it nests routes under a path prefix?
There was a problem hiding this comment.
I think what you say is not wrong, but I find prefix more intuitive. Akka http calls it pathPrefix in their routing api, play has SimpleRouter#withPrefix. I think prefix is quite right.
jdegoes
requested changes
Dec 8, 2023
7adf00f
to
0bed16a
Compare
0bed16a
to
d30f311
Compare
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.