-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conditional rescan #1284
Merged
fluidvanadium
merged 17 commits into
zingolabs:dev
from
fluidvanadium:conditional_rescan
Jul 13, 2024
Merged
Conditional rescan #1284
fluidvanadium
merged 17 commits into
zingolabs:dev
from
fluidvanadium:conditional_rescan
Jul 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_reorged_height test, needs more explanation in comments
this is not going to work so long as scan_full_tx is broken |
fluidvanadium
force-pushed
the
conditional_rescan
branch
from
July 10, 2024 19:23
12ec7d7
to
47aea70
Compare
zancas
reviewed
Jul 10, 2024
im working on it! |
Oscar-Pepper
approved these changes
Jul 13, 2024
This introduced 1 serious bug, that we almost didn't catch... and some unknown number of bugs that we are not aware of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditional rescan if output indexes are missing!