Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add portuguese translation #96

Merged
merged 27 commits into from
Jan 15, 2021
Merged

Conversation

kassane
Copy link
Contributor

@kassane kassane commented Jan 13, 2021

No description provided.

@kassane kassane changed the title Master portuguese add portuguese translation Jan 13, 2021
Copy link
Contributor

@nyaa8 nyaa8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! 😊
I think there is going to be a problem with loading pex-white.svg and pex-black.svg in content/_index.pt.md (line 111 and 112) as they are static assets served at /.

content/_index.pt.md Outdated Show resolved Hide resolved
@kristoff-it
Copy link
Member

Thank you very much for contributing this translation!

Awesome job translating all those pages, I still am lagging behind with the italian version :)

I'll add a few comments, but first of all please pull from master so that you can get in sync. One important addition that you don't have access to right now is the ability to add lang="pt" to the slogan tag in content/_index.pt.md.

Once you pull from master you'll be able to change it like so:

{{< slogan get_started="COMECE AGORA" docs="Documentação" notes="Mudanças" lang="pt">}}

I'll also leave a couple comments in a moment.

@kassane
Copy link
Contributor Author

kassane commented Jan 13, 2021

Okay! At the moment I'm not on the PC, but it's already synchronized.

Copy link
Member

@kristoff-it kristoff-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done reviewing, thank you again for the huge help.

If you have any questions please don't hesitate to ask.

content/_index.pt.md Outdated Show resolved Hide resolved
content/_index.pt.md Outdated Show resolved Hide resolved
content/_index.pt.md Outdated Show resolved Hide resolved
content/learn/_index.pt.md Outdated Show resolved Hide resolved
content/learn/getting-started.pt.md Outdated Show resolved Hide resolved
content/learn/getting-started.pt.md Outdated Show resolved Hide resolved
content/learn/getting-started.pt.md Outdated Show resolved Hide resolved
content/zsf/index.pt.md Outdated Show resolved Hide resolved
Copy link
Member

@kristoff-it kristoff-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I just suggested a couple of final fixes to some links.

We're at the end, I just need to ask you to be patient because I'm about to merge a fix for #99 which will add a few final lines to translate. I'll let you know when it is merged and how to do the translation.

After we're done with that I'll be ready to merge (no need for more reviews) :)

Thanks again!

content/_index.pt.md Outdated Show resolved Hide resolved
content/_index.pt.md Outdated Show resolved Hide resolved
content/_index.pt.md Outdated Show resolved Hide resolved
content/zsf/index.pt.md Outdated Show resolved Hide resolved
content/learn/overview.pt.md Outdated Show resolved Hide resolved
@kassane
Copy link
Contributor Author

kassane commented Jan 14, 2021

We're at the end, I just need to ask you to be patient because I'm about to merge a fix for #99 which will add a few final lines to translate. I'll let you know when it is merged and how to do the translation.

Okay!

I thank you for your patience, since translating languages from different vocabulary is not that easy.

I encourage others who understand portuguese to consume and contribute to this project.
Including the language documentation.

@kristoff-it
Copy link
Member

There are 3 new variables in i18n/en.toml, pull from master to obtain them. I'll list them here for convenience:

[slogan-latest-release]
other = "Latest Release: &nbsp; <b>{{ . }}</b>"


[downloads-heading]
other = "Releases"

[downloads-install-from-pkg-manager]
other = "You can also <a href=\"https://github.com/ziglang/zig/wiki/Install-Zig-from-a-Package-Manager\"> install Zig from a package manager</a>."

[downloads-json]
other = "There is a <a href=\"https://ziglang.org/download/index.json\">JSON version of this page</a>."

WIth this we're done. Thank you again.

@kristoff-it
Copy link
Member

@kassane let me know when you're ready to merge :)

@kassane
Copy link
Contributor Author

kassane commented Jan 15, 2021

@kristoff-it , done!
All the adjustments that needed to be corrected and I even readapted some terms more succinctly.

@kristoff-it
Copy link
Member

Thank you very much for your contribution!

If you happen to drop by any of the Zig communities on Discord make sure to say hi!

@kristoff-it kristoff-it merged commit eb091c0 into ziglang:master Jan 15, 2021
andrewrk pushed a commit that referenced this pull request May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants