This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Issue18 #20
Merged
Issue18 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 19, 2018 15:43
# Conflicts: # test/Factory/RpcControllerFactoryTest.php
…ncyLookupCondition to demonstrate an issue with a double wrapped callable
While we were correctly detecting a circular dependency condition within the factory method itself, we needed to prevent a circular _lookup_ as well, which occurs when the plugin manager calls `has()` on the service. This patch adds a check to see if the service being checked is the same as the last one being created; if so, it returns true to ensure we do not attempt a second creation.
| @@ -326,5 +330,20 @@ public function testFactoryDoesNotEnterACircularDependencyLookupCondition() | |||
|
|
|||
| $controller = $controllerManager->get(TestAsset\Foo::class); | |||
| $this->assertInstanceOf(RpcController::class, $controller); | |||
|
|
|||
| $wrappedCallable = Assert::readAttribute($controller, 'wrappedCallable'); | |||
There was a problem hiding this comment.
$this->readAttribute and we don't need import Assert.
We need to use a different RouteMatch class based on whether zend-mvc v2 or v3 is in place.
weierophinney
added a commit
that referenced
this pull request
Jan 22, 2019
weierophinney
added a commit
that referenced
this pull request
Jan 22, 2019
Forward port #20 Conflicts: CHANGELOG.md
|
Thanks, @Wilt, for the great test case! Fixed now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for test case as requested by @weierophinney here: #18 (comment)