This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
Prevent circular dependency lookup in RpcControllerFactory #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in zfcampus#18, a circular dependency lookup can occur when specifying a static method of a class as a `callable` for an RPC service that matches the class name for the RPC service. As an example: ```php return [ 'zf-rpc' => [ SomeController::class => [ 'callable' => SomeController::class . '::bar', ], ], ]; ``` In the above case, the `RpcControllerFactory` would be invoked for `SomeController::class`, find the `callable` entry of `{NS}\SomeController::bar`, split this into the class and method, and then attempt to fetch `SomeController::class` again, ad infinitum. This patch adds a private property, `$lastRequestedControllerService`, which is set to the service being pulled whenever we attempt to marshal a service from the controller manager. If a subsequent invocation finds that the service requested matches that property value, then we do not attempt to pull from the controller manager again, but move on to the parent container (if we have one), or directly instantiating the class. (The `$lastRequestedControllerService` is reset otherwise.) Fixes zfcampus#18
weierophinney
force-pushed
the
hotfix/18-controller-classes-as-rpc
branch
from
474fcb4
to
6143763
Compare
weierophinney
added a commit
that referenced
this pull request
Jan 7, 2019
weierophinney
added a commit
that referenced
this pull request
Jan 7, 2019
weierophinney
added a commit
that referenced
this pull request
Jan 7, 2019
Forward port #19 Conflicts: CHANGELOG.md
|
Great, thanks for providing a solution to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #18, a circular dependency lookup can occur when specifying a static method of a class as a
callablefor an RPC service that matches the class name for the RPC service. As an example:In the above case, the
RpcControllerFactorywould be invoked forSomeController::class, find thecallableentry of{NS}\SomeController::bar, split this into the class and method, and then attempt to fetchSomeController::classagain, ad infinitum.This patch adds a private property,
$lastRequestedControllerService, which is set to the service being pulled whenever we attempt to marshal a service from the controller manager. If a subsequent invocation finds that the service requested matches that property value, then we do not attempt to pull from the controller manager again, but move on to the parent container (if we have one), or directly instantiating the class. (The$lastRequestedControllerServiceis reset otherwise.)Fixes #18