Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems like streamSignalingDelegates in ECSignalingChannel contains ECClient, so it causes retain cycle. #85

Open
allenlinli opened this issue Jan 7, 2019 · 2 comments

Comments

@allenlinli
Copy link
Contributor

I am fixing a bug that caused by retain cycle between ECSignalingChannel and ECClient.
I found streamSignalingDelegates retain ECClient strongly in NSMutableDictionary from, so it has retain cycle. Should we avoid this retain cycle since subscribeClient and publish client should be released if needed after disconnection?

@zevarito
Copy link
Owner

zevarito commented Jan 7, 2019 via email

@ashar02
Copy link
Contributor

ashar02 commented Jan 9, 2019

I am facing same problem. Are you sending PR or changes here? It happens to me when I quickly connect and then disconnect the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants