-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seems like streamSignalingDelegates
in ECSignalingChannel
contains ECClient
, so it causes retain cycle.
#85
Comments
Hi Li Lin, I am not able to work on it right now, if you want to submit PR
please go ahead.
El lun., 7 de ene. de 2019 a la(s) 00:46, Li Lin ([email protected])
escribió:
… I am fixing a bug that caused by retain cycle between ECSignalingChannel
and ECClient.
I found streamSignalingDelegates retain ECClient strongly in
NSMutableDictionary from, so it has retain cycle. Should we avoid this
retain cycle since subscribeClient and publish client should be released if
needed after disconnection?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#85>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACgaueUty5oxD7tZnjr-NX7f0lMiM32ks5vAsMAgaJpZM4Zy0S5>
.
--
Alvaro
|
I am facing same problem. Are you sending PR or changes here? It happens to me when I quickly connect and then disconnect the call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am fixing a bug that caused by retain cycle between
ECSignalingChannel
andECClient
.I found
streamSignalingDelegates
retainECClient
strongly in NSMutableDictionary from, so it has retain cycle. Should we avoid this retain cycle since subscribeClient and publish client should be released if needed after disconnection?The text was updated successfully, but these errors were encountered: