Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bazel support #605

Closed
wants to merge 1 commit into from
Closed

Conversation

Vertexwahn
Copy link

@Vertexwahn Vertexwahn commented Jan 7, 2024

This PR helps users of the Bazel build system to integrate pugixml in their builds.

Supporting the Bazel build systems is of course more effort to maintain but helps to spread pugixml.
In the worst case the Bazel build path does simply not work - in the best case, someone who uses Bazel can benefit from it.

Also, other projects support Bazel side by side to other build systems (e.g. Catch2, gtest, etc.).

I will maintain the pugixml Bazel build at least for a half year.

@Vertexwahn Vertexwahn force-pushed the bazel-support branch 3 times, most recently from dd798d2 to 6cac317 Compare February 11, 2024 00:29
@zeux
Copy link
Owner

zeux commented Jul 8, 2024

Thanks for the PR! I do not plan to add more alternative build systems: there’s a few alternatives to CMake that people use, and I would prefer to keep it constrained. External projects are free to define their own build wrappers, add pugixml.cpp to some project (it’s just one file) or use header only mode. See also #443.

@zeux zeux closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants