Added cmake option to disable install rules #585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pugixml is used as a submodule, installation rules are not required.
Additionally, it may cause issues when pugixml is installed / exported by parent project:
Parent projects now can set
set(PUGIXML_INSTALL OFF)
to disable installation rules.It's a good practice to provide such option. Example is https://github.com/nlohmann/json/blob/develop/CMakeLists.txt#L47