build: only include CTest when building the pugixml tests #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was always set by including CTest, now CTest is conditionally included later on
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CMakeLists.txt unconditionally includes CTest. As a consequence, BUILD_TESTING is defined by CTest, which has unintended consequences for any project that uses pugixml: a project that has a certain configuration in which the tests are disabled suddenly finds that testing is enabled after including pugixml.
By making include(CTest) conditional on PUGIXML_BUILD_TESTS, BUILD_TESTING is not set anymore in other projects.