Fixed 'Undefined offset: -1' notice. #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derickr
requested changes
Oct 7, 2016
There was a problem hiding this comment.
As this is a parser-only related issue, could you add a test case please?
There is an example data file at https://github.com/zetacomponents/Mail/blob/master/tests/parser/data/various/test-bounced
|
I added a test and used Lots of other tests seem to fail. |
|
Happy to merge this - but can you please split the commit in two - one for the real fix, and one for the white space changes? |
|
I removed the whitespace change. |
derickr
added a commit
that referenced
this pull request
Nov 18, 2017
|
Merged (After rebase, and a change). Thanks for helping out @danez and @marceltoben ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change avoids a php notice.