Toggle rotateLayout automatically to support vertical outputs #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flip rotateLayout setting when engine is created if output width is less than height.
For newly introduced variable, use a name that is consistent with the rest of the code.
|
Core functionality change is in file |
autoRotateLayout is a global option that changes the per-output rotateLayout setting at driver creation phase. It has no meaning as per-output setting, hence removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically toggle "Rotate layout" if desktop/output width is less than its height. This makes layout engines to split along the major output axis first. For example, vertical outputs will first split vertically when using btree engine.
The change honors the "Rotate layout" setting in the UI by toggling its value instead of overriding it.
A new UI setting "Auto rotate layout" has been added and enabled by default.