Problem: Fix misspelling & out-of-sync zproject #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: comitted => committed
Solution: Run `gsl project.xml`
|
I noticed @tblattner made a change in the zproject-generated file that this is now reversing: #1330 Do you have context on what issue you were having @tblattner? as generally I see warnings that the variable name casing should be the same as package. Perhaps the solution to whatever issue you were having is related to changing |
|
Radio silence from @tblattner. I would like to go ahead and push this through @bluca or know what you would like to see to get it in. |
|
Why did gsl_FOUND change to lower case? |
It is a result of running Changing it to all caps was a manual modification from #1330 which this effectively reverts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: Fix the misspelling in the .gsl and re-run it.
This was initially found in czmq where a committed changed a generated file and the misspelling came back once I generated. This should fix it upstream so that it fixes all downstream.
CZMQ should not need re-generated after this merge because it already had the misspelling fixed. See zeromq/czmq#2283