Handle codec errors in REQ socket recv #172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there.
This PR handles codec errors when reading from a REQ socket and thus makes the code more resilient to abrupt changes in the underlying tcp connection. In my experience, it was relatively easy to make the panic happen during tests.
Not sure what's planned for the
Some(Ok(_))
arm, so I've left it astodo()
.Hope this helps. Please let me know if I should do anything particular with the PR. Cheers!