Perl 5.38.0 deprecates when keyword

[zmughal]

Fixes #51.

Also some CI / Docker fixes:

• CI: Update Perl matrix up to Perl 5.38: in order to test against Perl 5.38.
• CI: Update actions versions: See https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/.
• Install Sys::SigAction in test environment image: This will require a new Docker image to be pushed.

[zmughal]

@ghenry, this is ready for review. The three failures that happen here are due to:

1. Missing Sys::SigAction. If the Docker image is rebuilt with the changes to the Dockerfile above, then it will pass.
2. Some fixes that I need to do for Alien::ZMQ::latest. I'll have those in by probably later today and then rerun the build.

[zmughal]

@ghenry, the PR should pass now. The macOS failure here should go away with a rerun of that job (it probably grabbed the old version of Alien::ZMQ::latest as I just released a new version). That build passes here.

Aside: I didn't know you were a host of SE Radio. I've listened to many of those specific episodes! Great content as those are the kind of things I'm interested in.

[zmughal]

@ghenry, have a moment to review this?

[ghenry]

Ah sorry. Been working on my other projects https://github.com/SentryPeer

Will do tonight.

[ghenry]

@ghenry, the PR should pass now. The macOS failure here should go away with a rerun of that job (it probably grabbed the old version of Alien::ZMQ::latest as I just released a new version). That build passes here.

Merged.

Aside: I didn't know you were a host of SE Radio. I've listened to many of those specific episodes! Great content as those are the kind of things I'm interested in.

Ah, thanks. Very kind of you to say so.

[zmughal]

Thank you! Whenever you get a moment, could you get this on to CPAN? I see that this appears to be the only major issue with the current release as per CPAN Testers.

[ghenry]

Just going over all the steps again now that we discussed in #47 (comment)

[ghenry]

Things updating now https://hub.docker.com/r/calid/perl-zmq-base/tags

[ghenry]

All done.

[zmughal]

Excellent! Thank you! I see that the ZMQ-FFI 1.19 tests are looking good here. I have also notified Perl/perl5#21027.

[zmughal]

Just one thing to add for next time: update the changelog. I really should have done it in the PR to make things easier. In my own Dist::Zilla configurations I use https://metacpan.org/pod/Dist::Zilla::Plugin::CheckChangeLog because otherwise I may forget.

[ghenry]

Doh! I thought it was just ready to push. Sorry.

…

On Fri, 4 Aug 2023, 20:44 Zaki Mughal [sivoais], ***@***.***> wrote: Just one thing to add for next time: update the changelog. I really should have done it in the PR to make things easier. In my own Dist::Zilla configurations I use https://metacpan.org/pod/Dist::Zilla::Plugin::CheckChangeLog because otherwise I may forget. — Reply to this email directly, view it on GitHub <#52 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABG66H4Y6G3R7HM35XZJZ3XTVGIVANCNFSM6AAAAAA2PKB7OE> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>