Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: Renesas #55167

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Conversation

str4t0m
Copy link
Collaborator

@str4t0m str4t0m commented Feb 24, 2023

I noticed that all new PRs for the Smartbond SoCs were wrongly assigned to the R-Car platform therefore I am proposing the following commits.

  • rcar: limit dts scope to gen3 folder
    • After the introduction of the Renesas Smartbond family the scope of dts
      files needs to be limited to the R-Car subfolder.
  • add new MAINTAINERS entry for Renesas (smartbond)
    • Renesas platform only had an entry for the maintainer of the HAL, but not for Zephyr drivers etc.

As @andrzej-kaczmarek is the maintainer of the HAL I assume that he is also maintaining the zephyr side, please let me know if this is no longer the case.
See also HAL module request, introduction of platform, and PR Renesas HAL maintainer

@str4t0m
Copy link
Collaborator Author

str4t0m commented Feb 24, 2023

Btw. it seems that @pmarzin has not been added to the collaborator list, is he still collaborating on the R-Car platform?

@nashif
Copy link
Member

nashif commented Feb 24, 2023

@str4t0m what is you relation to Renesas and this platform? The platform was originally submitted by someone else. @andrzej-kaczmarek

@str4t0m
Copy link
Collaborator Author

str4t0m commented Feb 24, 2023

@nashif I don't don't have any relation to Renesas. Checking new PRs I just noticed that all new smartbond PRs from @blauret were assigned to Renesas R-Car, therefore I had a look why this is happening and attempted to fix it.
I have tried to mention maintainers of the platforms and posted a link to the PR in the Renesas Discord group asking for feedback. Please let me know if I am acting too pushy here.

@nashif
Copy link
Member

nashif commented Feb 24, 2023

@str4t0m appreciate that you want to step in, but in this case we need to wait for the original contributors.

@nashif
Copy link
Member

nashif commented Feb 24, 2023

sorry, long day, for misread the change and thought you are claiming maintainership for this, which is not the case :)

nashif
nashif previously approved these changes Feb 24, 2023
blauret
blauret previously approved these changes Feb 25, 2023
Copy link
Member

@aaillet aaillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @str4t0m, sorry for the delay, I was on holidays.
Thank you for your suggestion, I had planned to correct this problem soon so that's fine.

@pmarzin is indeed still a collaborator on the "renesas r-car" part.

The only suggestion I would have is to name the new area and label "Renesas Smartbond" as you are precisely delimiting target files to this soc family.
I saw that you wanted to delimit this area to "not r-car socs" but because of how file tree is done right now, you can't really do that.

MAINTAINERS.yml Outdated Show resolved Hide resolved
MAINTAINERS.yml Outdated Show resolved Hide resolved
MAINTAINERS.yml Outdated Show resolved Hide resolved
MAINTAINERS.yml Show resolved Hide resolved
MAINTAINERS.yml Outdated Show resolved Hide resolved
After the introduction of the renesas smartbond family the scope of dts
files needs to be limited to the rcar subfolder.

Signed-off-by: Thomas Stranger <[email protected]>
Renesas SmartBond platform only had an entry for the maintainer of the hal.

Signed-off-by: Thomas Stranger <[email protected]>
@MaureenHelm MaureenHelm merged commit 0eeb5c7 into zephyrproject-rtos:main Mar 3, 2023
@str4t0m str4t0m deleted the renesas_maintainers branch March 3, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants