Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependency promisify #1534

Merged
merged 42 commits into from
Jun 27, 2024
Merged

Remove unused dependency promisify #1534

merged 42 commits into from
Jun 27, 2024

Conversation

benjamintd
Copy link
Contributor

This removes the promisify dependency which is unused.

This dependency itself depends on "when": "", which, not declaring a version, breaks certain package managers like Bun.

Copy link
Contributor

coderabbitai bot commented Jun 25, 2024

Walkthrough

Walkthrough

This update focuses on pinning the versions for prisma and @prisma/client to 5.15.x across a test scaffold script and integration tests. This ensures consistent and predictable behavior tied to specific versions of these packages, which helps avoid potential issues caused by incompatible updates in newer versions.

Changes

File Change Summary
script/test-scaffold.ts Pinned versions of prisma and @prisma/client to 5.15.x in the npm install command.
tests/integration/tests/cli/plugins.test.ts Updated version references for prisma and @prisma/client from ^5.0.0 to 5.15.x.

Possibly related issues


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ymc9 ymc9 changed the base branch from main to dev June 26, 2024 09:19
@ymc9
Copy link
Member

ymc9 commented Jun 26, 2024

Thanks for making the change @benjamintd ! It looks good to me and I'll merge once the CI passes.

ymc9
ymc9 previously approved these changes Jun 26, 2024
@benjamintd
Copy link
Contributor Author

Thank you @ymc9 for updating the lockfile. I made the edit in the Github UI after checking that the dependency was unused, but did not get to installing the project on my machine to do it.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3e77974 and c896b67.

Files ignored due to path filters (6)
  • packages/schema/package.json is excluded by !**/*.json
  • packages/sdk/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml
  • tests/integration/test-run/package.json is excluded by !**/*.json
  • tests/integration/tests/frameworks/nextjs/test-project/package.json is excluded by !**/*.json
  • tests/integration/tests/frameworks/trpc/test-project/package.json is excluded by !**/*.json
Files selected for processing (2)
  • script/test-scaffold.ts (1 hunks)
  • tests/integration/tests/cli/plugins.test.ts (2 hunks)
Files skipped from review due to trivial changes (2)
  • script/test-scaffold.ts
  • tests/integration/tests/cli/plugins.test.ts

@ymc9
Copy link
Member

ymc9 commented Jun 27, 2024

Thank you @ymc9 for updating the lockfile. I made the edit in the Github UI after checking that the dependency was unused, but did not get to installing the project on my machine to do it.

No worries. I've also found another issue caused by not pinning Prisma dependency's minor version. Prisma 5.16 introduced a breaking change.

@ymc9 ymc9 merged commit 64c89f8 into zenstackhq:dev Jun 27, 2024
12 checks passed
@benjamintd benjamintd deleted the patch-1 branch June 28, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants