Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add state object for scripting engine #2064

Merged
merged 3 commits into from
Nov 28, 2023
Merged

add state object for scripting engine #2064

merged 3 commits into from
Nov 28, 2023

Conversation

kellertobias
Copy link
Contributor

@kellertobias kellertobias commented Nov 17, 2023 •
edited

This is my first shot on tackling #2063

What this changes:

  • it introduces a new state that can be carried over multiple calls of process_row
  • It adds tests for scripting engine and the new changes

@osheroff
Copy link
Collaborator

well, can you install java? This looks plausible, but it doesn't compile...

@kellertobias
Copy link
Contributor Author

@osheroff I have finally found the time to install java and fix the problem. I also have written some tests and updated the documentation.

@osheroff
Copy link
Collaborator

thanks keller.

@osheroff osheroff merged commit fad6c75 into zendesk:master Nov 28, 2023
1 check passed
@kellertobias kellertobias deleted the feat/javascript-filter-state branch November 28, 2023 16:52
@colinmollenhour colinmollenhour mentioned this pull request Nov 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kellertobias @osheroff