datetime columns timezone conversion fix #1779
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kinda scary and deep. might work, but would need far more tests around various behaviors. |
|
@osheroff, as mentioned in the issue, I've run some tests and confirmed the fix works for datetimes of any precision, making the bootstrapping process coherent with CDC's behavior of replicating datetime values as stored. What further tests would you suggest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported here, although mysql datetime values are not stored with any timezone information, Maxwell bootstrap utility adds it to them based on database's timezone, and then proceeds to convert them to client server timezone. Such unexpected behavior does not occur in the CDC process.
This is an attempt on avoiding the problem by treating datetime values as simple strings.