Enrich the hours validation experience #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the validation logic operated on the raw configuration, which provides many avenues for invalid configuration to slip through the cracks unless a litany of cases is tested. By now having the validation logic operate on the instantiated configuration object, instead of the underlying raw data, we're able to catch many more cases of bad configuration with less code that, at the same time, is more expressive. Closes #130.
8a26299
to
c7d1130
Compare
alex-stone
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the validation logic operated on the raw configuration, which provides many avenues for invalid configuration to slip through the cracks unless a litany of cases is tested.
By now having the validation logic operate on the instantiated configuration object, instead of the underlying raw data, we're able to catch many more cases of bad configuration with less code that, at the same time, is more expressive.
Closes #130.