Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore keywords to search box #6490

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Restore keywords to search box #6490

merged 1 commit into from
Jul 8, 2024

Conversation

drbyte
Copy link
Member

@drbyte drbyte commented May 26, 2024

Ref #6483

@drbyte
Copy link
Member Author

drbyte commented May 26, 2024

Open to discussion before merge ...

proseLA
proseLA reviewed May 28, 2024
View reviewed changes
Copy link
Sponsor Contributor

@proseLA proseLA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i left some code comments... i'm not sure if they are showing up!

oh, i commented on your commit (in your repo. let me know if you want to repost them here.

@scottcwilson
Copy link
Sponsor Contributor

Is this ready to merge?

@drbyte drbyte marked this pull request as draft June 29, 2024 15:34
@proseLA
Copy link
Sponsor Contributor

proseLA commented Jul 1, 2024

i'm good with whatever chris wants to do. the code conversation and differences, as i recollect, were quite minor.

@drbyte drbyte marked this pull request as ready for review July 8, 2024 23:49
@drbyte drbyte merged commit 36cc283 into zencart:master Jul 8, 2024
8 checks passed
@drbyte drbyte deleted the search-keywords branch July 8, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proseLA proseLA proseLA left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drbyte @scottcwilson @proseLA