Add product dimension fields

[drbyte]

Add product dimension fields. Primarily to be used by shipping modules to prepare more accurate shipping quotes.

Also addresses #6232

[scottcwilson]

Love it! Looks like Canada Post. :)

[scottcwilson]

New doc: https://docs.zen-cart.com/user/shipping/shipping_dimensions/ plus references in What's New and the Release Specific Upgrade Considerations pages.

[torvista]

Couple of typos

[scottcwilson]

Couple of typos

Thank you, @torvista. The first one I already had but the second one was a surprise. Will push these shortly.

[brittainmark]

Should these be UPPER case
'TEXT_SHIPPING_LBS' => '(lbs)',
etc

[drbyte]

See PR #6245

[piloujp]

If I understand well, this file is overridden by other collect_info.php in different products types folders. Shouldn't these be updated too?

[drbyte]

See PR #6245

[drbyte]

In v2.0.0 they're consolidated into a parent directory unless you're customizing them, in which case you copy the original into that product type dir. I guess we could add it to the built in music one.

[neekfenwick]

I just tried to monkey patch my database using the SQL added here, but it fails because there's a MODIFY on products_length which does not exist:

zencart/zc_install/sql/updates/mysql_upgrade_zencart_200.sql

Lines 44 to 45 in 119d28c

	ALTER TABLE products MODIFY products_length DECIMAL(8,4) DEFAULT NULL;
	ALTER TABLE products ADD products_length DECIMAL(8,4) DEFAULT NULL AFTER products_weight;

In fact, why does this SQL attempt to MODIFY and then ADD the same field? The MODIFY line appears redundant. Same goes for the width and height lines just below.

[scottcwilson]

I just tried to monkey patch my database ...

If you're doing that, remove the ALTER TABLE MODIFY statements. These were put in place for people who already had these fields because of mods (like Numinix Product Fields).

[neekfenwick]

If you're doing that, remove the ALTER TABLE MODIFY statements. These were put in place for people who already had these fields because of mods (like Numinix Product Fields).

Ah, there's obviously some black magic going on in zc_install that I'm unaware of 👍 Thanks.

[scottcwilson]

Please note: FOR LIVE-STORES THAT HAVE NOT RUN ZC_INSTALL, the guidance is to not do what you're doing. That's why it says in red text in the Install SQL Patches tool:

This tool should NOT be used to execute Zen Cart database-upgrade scripts: use the Zen Cart Installer as per the documentation.

If you still want to do it, you have to dig in and understand the details.

[drbyte]

Ah, there's obviously some black magic going on in zc_install that I'm unaware of 👍 Thanks.

Yes, both zc_install and Install SQL Patch will check whether add/change/modify/drop operations, and some insert operations, would fail due to required dependencies, and simply skip running those statements. It logs it to upgrade_exceptions table and the logs directory, and the admin will display the alert ... but the script will not fail.
This is why Zen Cart upgrades can do all their SQL changes with just .sql files instead of having to write PHP code specific to every version upgrade. It also means one "can" copy/paste the statements into phpmyadmin or sqlpatch in most cases without side-effects. (The reason that "the guidance" says "not" to do that, is because uninformed end-users tend to cherrypick things and assume they did enough, and then come on the forum asking why their site isn't working after "upgrading" when they didn't follow the complete upgrade.) zc_install is still important for most upgrades because it does use PHP code to check various dependencies and fix incompatible situations; and also upgrade configure.php if it's in an old format, etc.