Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refac: small fix on table text padding #63

Closed
wants to merge 5 commits into from

Conversation

Cauatn
Copy link

@Cauatn Cauatn commented Aug 23, 2024

Also made it better semantic in the header and footer, Lint automatically formatted for more consistent indentation, think not gonna make much difference tho.

Before:
image

In PR:
image

Copy link

vercel bot commented Aug 23, 2024

@Cauatn is attempting to deploy a commit to the Zen Browser Team on Vercel.

A member of the Team first needs to authorize it.

@Cauatn Cauatn changed the title refac: small fix on table padding refac: small fix on table text padding Aug 23, 2024
@ktz-dev
Copy link
Contributor

ktz-dev commented Aug 25, 2024

This addresses the issue I just raised #86 but it's still using paddings and margins to shift the things around to look centered. If you use static-width padding/margins to make something look centered then any changes to the parents width (whether intentional or not) will lead to the child being off center. Read the suggested fix on my issue and let me know what you think.

@Cauatn
Copy link
Author

Cauatn commented Aug 25, 2024

i couldn't do it better :), ty for the comment.

now:
WhatsApp Image 2024-08-25 at 10 36 48
before:
WhatsApp Image 2024-08-25 at 10 36 32

Copy link
Contributor

@ktz-dev ktz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks for that. Sorry idk how to use GitHub. I reviewed your PR and here are some changes to get the columns consistent widths. Thanks for your patience.

Here is the table after making these changes:

Screenshot 2024-08-26 at 9 58 32 AM Screenshot 2024-08-26 at 9 59 15 AM

src/components/features.tsx Outdated Show resolved Hide resolved
src/components/features.tsx Show resolved Hide resolved
src/components/features.tsx Outdated Show resolved Hide resolved
src/components/features.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@ktz-dev ktz-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me 👍. Fixes #111 and #86. Just need to resolve merge conflicts.

Screenshot 2024-08-29 at 9 05 44 AM Screenshot 2024-08-29 at 9 06 11 AM

@ktz-dev
Copy link
Contributor

ktz-dev commented Aug 30, 2024

They updated the features page. This table isn't there anymore.

@lawlesx
Copy link

lawlesx commented Sep 1, 2024

They updated the features page. This table isn't there anymore.

I think its better to close the issue and pr and not let it hang around

@Cauatn
Copy link
Author

Cauatn commented Sep 1, 2024

i agree

@Cauatn Cauatn closed this Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants