-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refac: small fix on table text padding #63
Conversation
@Cauatn is attempting to deploy a commit to the Zen Browser Team on Vercel. A member of the Team first needs to authorize it. |
This addresses the issue I just raised #86 but it's still using paddings and margins to shift the things around to look centered. If you use static-width padding/margins to make something look centered then any changes to the parents width (whether intentional or not) will lead to the child being off center. Read the suggested fix on my issue and let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They updated the features page. This table isn't there anymore. |
I think its better to close the issue and pr and not let it hang around |
i agree |
Also made it better semantic in the header and footer, Lint automatically formatted for more consistent indentation, think not gonna make much difference tho.
Before:
In PR: