Simplify geometry stuff #60
Conversation
| fn _debug_log_to_file(message: String) { | ||
| use std::fs::OpenOptions; | ||
| use std::io::prelude::*; | ||
| let mut file = OpenOptions::new() | ||
| .append(true) | ||
| .create(true) | ||
| .open("/tmp/mosaic-log.txt") | ||
| .unwrap(); | ||
| file.write_all(message.as_bytes()).unwrap(); | ||
| file.write_all("\n".as_bytes()).unwrap(); | ||
| } |
There was a problem hiding this comment.
I'm not a terrible enough person to leave this in - will pick up the logging functionality
| } | ||
| } | ||
|
|
||
| #[derive(PartialEq, Eq, Hash, Debug)] | ||
| pub struct Coordinates { | ||
| pub struct ScreenCanvas { |
There was a problem hiding this comment.
The thinking here was potentially to have a more generic type for "Rectangle that can contain other rectangles and knows some stuff about what needs to be drawn". This may already be covered by terminal_pane or similar, I'm not sure
| columns: usize, | ||
| rows: usize, | ||
| boundary_characters: HashMap<Coordinates, BoundaryType>, | ||
| borders: HashMap<EdgeType, usize>, |
There was a problem hiding this comment.
I think it should probably also have a children: Box<Vec<ScreenCanvas>> or similar too
There was a problem hiding this comment.
I like everything about this PR except this...
Most multiplexers keep data in this way, and while it's very comfortable for us developers it creates some issues for the users. For example, if we want to resize a pane outside of its parent. This can happen for example where:
- we have 4 rectangles on screen (by splitting horizontally and then splitting each one of the halves vertically)
- we resize the bottom-right pane up
- we then resize it back down to where it was
- we resize the same pane left
To my knowledge, we're the only multiplexer that supports this. Every other multiplexer would drag the pane's sibling with it in at least one of these directions. And I think it's because they keep a hierarchical map of the panes.
|
Just leaving a note saying I haven't forgotten this and will take a closer look sometime this week |
|
@imsnif it's very much not ready yet - I've been raising draft PRs early so that people can get a chance to share input. Will convert them to full reviews when ready |
For sure, that's what I was talking about :) |
Planning to simplify some of the logic around drawing panes and add some geometry helper functionality.