fix: use ITU T.418 format for emitted CSI 58 sequences #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imsnif
reviewed
Jun 21, 2024
|
Thanks for this! I'm happy to see this issue resolved for the joint users of Zellij and windows terminal. Just for the record, as specified in the linked issue: I see this as a workaround for an issue in windows terminal. I mean this in the most blameless way possible, but in case we find that this workaround causes issues in other terminals in a way that cannot be consolidated, we'll have to undo it and hope that the windows terminal folks fix the issue on their side in one way or another. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses microsoft/terminal#17426 on our side.
Tested both on nightly wezterm on Windows WSL2, and on a native linux wezterm for a cursory regression check.