Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add name section in readme #3391

Merged
merged 2 commits into from
Jun 14, 2024
Merged

add name section in readme #3391

merged 2 commits into from
Jun 14, 2024

Conversation

djalal
Copy link
Contributor

@djalal djalal commented May 30, 2024

added missing section to clarify the origin of the project name.

@IliasHad
Copy link

IliasHad commented Jun 2, 2024

+1

@giyany
Copy link

giyany commented Jun 3, 2024

Thank you for the PR!
Explaining the project name makes a lot of sense and telling more people about this beautiful, intricate art form is a huge bonus.

As a footnote, we're aware that there's been some political controversy about the origin and development of this art. Personally, my cultural background is distant enough so that I'm unable to have informed opinions on this topic. So while approving the PR is technically straightforward and fast, it may need some consideration of the best way to meet the code of conduct.

@imsnif
Copy link
Member

imsnif commented Jun 7, 2024

Hi, first - thanks for bringing attention to this issue. For the record, ever since we adopted the name the first word in the README linked to the wikipedia page for Zellij (and still does). But I am happy to make this more explicit and add the section you suggested.

In that venue, how about we use the first paragraph from wikipedia as the text:

Origin of the Name

From Wikipedia, the free encyclopedia

Zellij (Arabic: الزليج, romanized: zillīj; also spelled zillij or zellige) is a style of mosaic tilework made from individually hand-chiseled tile pieces. The pieces were typically of different colours and fitted together to form various patterns on the basis of tessellations, most notably elaborate Islamic geometric motifs such as radiating star patterns composed of various polygons. This form of Islamic art is one of the main characteristics of architecture in the western Islamic world. It is found in the architecture of Morocco, the architecture of Algeria, early Islamic sites in Tunisia, and in the historic monuments of al-Andalus (in the Iberian Peninsula).

What do you think @djalal ?

@djalal
Copy link
Contributor Author

djalal commented Jun 13, 2024

excellent, let's do this @imsnif

@imsnif
Copy link
Member

imsnif commented Jun 14, 2024

Great, thanks @djalal !

@imsnif imsnif merged commit 2ac8b15 into zellij-org:main Jun 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants