Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Wasmer to Wasmtime #3349

Merged
merged 10 commits into from
Jun 28, 2024
Merged

Switch from Wasmer to Wasmtime #3349

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7aa6462
Remove ForeignFunctionEnv wrapper around PluginEnv
bjorn3 May 13, 2024
e4312dc
Pass PluginEnv by value to load_plugin_instance
bjorn3 May 13, 2024
9fda2ba
Avoid passing a Store around when an Engine is enough
bjorn3 May 13, 2024
f63f18f
Pass PluginEnv to the wasi read/write functions
bjorn3 May 14, 2024
74a3b59
Migrate to Wasmtime
bjorn3 May 14, 2024
73bfd19
Switch from wasi-common to wasmtime-wasi
bjorn3 May 14, 2024
efd3fe2
Reduce verbosity of wasmtime_wasi logs
bjorn3 May 15, 2024
922801e
Increase startup delay
bjorn3 May 15, 2024
884b0da
Disable some wasmtime features
bjorn3 Jun 20, 2024
a05f412
Update to Wasmtime 21.0.1
bjorn3 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ Note that the output is truncated at 100KB. This can be adjusted for the purpose
When running Zellij with the `--debug` flag, Zellij will dump a copy of all bytes received over the pty for each pane in: `/$temp_dir/zellij-<UID>/zellij-log/zellij-<pane_id>.log`. These might be useful when troubleshooting terminal issues.

## Testing plugins
Zellij allows the use of the [Singlepass](https://crates.io/crates/wasmer-compiler-singlepass) compiler for wasmer. This can enable great gains in compilation time of plugins in detriment of stability, notably on Arm64 architectures.
Zellij allows the use of the singlepass [Winch](https://crates.io/crates/wasmtime-winch) compiler for wasmtime. This can enable great gains in compilation time of plugins at the cost of slower execution and less supported architectures.

To enable the singlepass compiler, use the `singlepass` flag. E.g.:
```sh
Expand All @@ -113,7 +113,7 @@ If you are new contributor to `Zellij` going through
[Discord server][discord-invite-link], we would be happy to help finding
something interesting to work on and guide through.

[discord-invite-link]: https://discord.gg/feHDHahHCz
[discord-invite-link]: https://discord.gg/feHDHahHCz
[good-first-issue]: https://github.com/zellij-org/zellij/labels/good%20first%20issue


Expand Down