fix(compact-bar): properly pad mode indicator #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiand391
commented
Apr 13, 2024
| @@ -199,7 +199,7 @@ fn tab_line_prefix( | |||
| tab_index: None, | |||
| }]; | |||
| if let Some(name) = session_name { | |||
| let name_part = format!("({}) ", name); | |||
| let name_part = format!("({})", name); | |||
There was a problem hiding this comment.
This is the session-name part, remove the whitespace on the right, the mode part will handle padding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the compact-bar plugin to make the mode indicator to be always centered.
before
mode indicator section hard-coded to 8-chars length, on mode names > 6 there's no padding
after
mode section gets printed as
<mode-name>, use a whitespace for padding.Closes #3248