-
-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/format UI components #3193
Conversation
Thinking about it again, I kind of want to have an But in the same time I’m not sure it will help format/print elements. It may be too much into the "gui framework" side, which is apparently already hard to do (at least in rust). What do you think ? PS: I’m thinking of having |
Hey @Zykino - sorry for taking so long to get to this and thanks for your patience! Any chance we can weed this down to just adding a simple serialization interface? I appreciate the thought you put into code reuse as well as improving existing build issues and such, but I have to minimize the surface of changes due to the size of this project and the burden of maintainership. Thanks for understanding. |
8ff6f72
to
499f081
Compare
|
hi @Zykino - thanks for your work and efforts on this. Can we please change this to just add the serialization interface without changing anything else? |
fe37fda
to
ef0d9eb
Compare
0b84261
to
ad3b71c
Compare
Thanks for this and for the changes! |
Add ways to serialize/format ui components instead of only proposing
print
options.I can remove the first commit if you want, but it did not work on my PC without it:
rust -vV
error when using the "previous" rust toolchain.protoc
complain thatoptional
is an experimental feature of the syntax3.I also changed the interface to borrow the
Text
elements instead of owning it, so it can be reused.I had some reflection on the
ribbon
: plugin developers will often want to have multiples of them in a row, so accepting aninto_iter
sounded nicer.I also wanted to have a possibility to color the full line with the background color, but I’m not sure how to get the bg color from the user’s theme.
Note: I changed the session plugin as needed and others, but I did not
run
everything plugin before/after. However I did not see obvious breakage in the "after" state.