Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compatibility): do not interpret esc as scroll-up #29

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

imsnif
Copy link
Member

@imsnif imsnif commented Nov 8, 2020

Some fixes here:

  • change scroll shortcuts to ctrl-pgup and ctrl-pgdown because ctrl-[ and ctrl-] were colliding with esc.
  • do not send trailing zeros to terminal because it was messing things up
  • fix test infrastructure to be able to support characters with more than one byte (eg. ctrl-pgup and ctrl-pgdown). This also introduces some much needed refactoring and clarity to the tests.

@imsnif imsnif merged commit ee0167f into zellij-org:main Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant