Fix 2205 - Support cwd

[Kangaxx-0]

#2205 - supports cwd as option

• Zellij options --default-cwd <path> without config
• Zellij with default_cwd = in zellij config file → set path to usr
• cargo xtask test

Screenshot

[imsnif]

Hey @Kangaxx-0 - good job with this! The code looks great and the solution very native.

Only issue I found is that when the default_cwd is set, whenever we open a new pane it is set to it instead of the current folder. This to me is more of an override_cwd than a default_cwd.

If we adjust this, I think we're good to merge.

[Kangaxx-0]

Only issue I found is that when the default_cwd is set, whenever we open a new pane it is set to it instead of the current folder. This to me is more of an override_cwd than a default_cwd.

If we adjust this, I think we're good to merge.

I changed it to override_cwd :)

[imsnif]

Hey @Kangaxx-0 - I think we need a default_cwd rather than an override_cwd (that's also what the issue was about). Would you like to work on it in that direction?

[Kangaxx-0]

Hi @imsnif - Sorry, I am bit confused here. In my initial commit, I used default_cwd, and I thought you would prefer override_cwd in your first comment, are you saying you feel default_cwd is better, and want me to change it back?

Besides the name change, any other change you feel we might need ?

[imsnif]

Hey @Kangaxx-0 - I just re-read my initial comment and realized I was very unclear, sorry about that!

What we want to do here is add a default_cwd option. This option should behave as follows:
When opening a new pane, it should be the default. Meaning that if we have another cwd from somewhere else (eg. from the previous pane we opened) we should use that one.
This means the default_cwd option should only be used at the beginning of the session or in cases where we can't read the cwd of an existing pane for some reason. In all other cases it's a better and expected experience (for most users) that the pane will be opened in the current location of the previously focused pane.

[Kangaxx-0]

@imsnif Thanks for your feedback, I've made some small changes, and I believe it works as you expected.

I have not sent new iteration, this is just my local changes, please let me know when I will update the new commit

[imsnif]

Hey @Kangaxx-0 - very elegant solution here! Only problem is that this now only works if a default_shell is defined... do you think we can find a solution that will work in any case?

[Kangaxx-0]

Hey @Kangaxx-0 - very elegant solution here! Only problem is that this now only works if a default_shell is defined... do you think we can find a solution that will work in any case?

Hello @imsnif, thanks for your comments, in order to make default cwd works without default_shell, I made a few changes to pass down a new param.

I've tested all below scenarios and they all worked fine

• no default_shell and no default_cwd
• no default_shell and default_cwd
• default_shell and no default_cwd
• default_shell and default_cwd

Please take a look when you get a chance, thanks

[imsnif]

Great work on this - thank you for bearing with all my change requests!