Fix plugin location path decoding from Url

[tarkah]

Using URL file schema for plugin location is currently broken in a couple different ways:

• Naively converting URL path to a PathBuf doesn't decode the percent encoded URL. This makes any path with "spaces" or percent encoded characters break.
• Using path or now w/ to_file_path always returns an "absolute" PathBuf. The root prefix is now stripped when adding it to the config directory for relative lookup.

I've tested both relative lookup file:plugin.wasm as well as absolute path w/ spaces and both now work.

[imsnif]

Hey @tarkah - thanks for looking into this!

Could you please add some tests (even if just unit tests for the changed functions) to clarify what's going on here? Barring that (if it's too complex to add a test suite here) maybe add very detailed comments with examples?

[tarkah]

Hey @tarkah - thanks for looking into this!

Could you please add some tests (even if just unit tests for the changed functions) to clarify what's going on here? Barring that (if it's too complex to add a test suite here) maybe add very detailed comments with examples?

No problem! I did a bit more digging and there is definitely an issue w/ the url dep and parsing file schema with relative data. It always adds an absolute forward slash. So when using path or to_file_path, it always returns an absolute path. This caused Path::join to just return the absolute path.

• I've added a new initial commit dcca532 includes a new unit test that fails.

• e182597 Instead of trying to extract a valid file path from a Url, it checks if the url is using relative data after the schema and instead uses the raw string to build the path from. Until the url dep is fixed upstream, this is the best way to handle this. This also ensures to decode the percent encoded path instead of using it directly when absolute path is passed or builtin tag is used.

• 939fd42 updates the unit test to check for paths with spaces. This would have previously failed as well.

[imsnif]

Thanks for this, the test looks great!