Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ScrollToTop action #2110

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

yves-biener
Copy link
Contributor

Closes #1940
Add new action ScrollToTop, which scrolls up to the top of the scroll log. The implementation is very similar to the already existing action ScrollToBottom. This also applies to the new test case for the new action.

I did not change the default keymap, as #1940 wants, but there is no documentation of the new action. Where can I add these, such that users find the new action?

@yves-biener yves-biener temporarily deployed to cachix January 24, 2023 12:16 — with GitHub Actions Inactive
@jaeheonji
Copy link
Member

Where can I add these, such that users find the new action?

If you can and want it, please update it to Zellij User Guide?
you can update docs to cli-commands.md and keybindings-possible-actions.md in this repo zellij-org.github.io

Copy link
Member

@jaeheonji jaeheonji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeheonji jaeheonji merged commit 650aeb1 into zellij-org:main Jan 24, 2023
@yves-biener yves-biener deleted the feat-scroll-to-top branch January 24, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ScrollToTop and assign default key bindings
2 participants